Skip to content

♻️ Shorten traefik config placeholder svc name #8217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2025
Merged

♻️ Shorten traefik config placeholder svc name #8217

merged 2 commits into from
Aug 14, 2025

Conversation

@YuryHrytsuk
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk commented Aug 14, 2025 •
edited
Loading

What do these changes do?

The name is service name is too long and causes >64 len char issue when deploying in prod. This fixes the problem by using a short name

To be hotfixed in v1.84.1

Related issue/s

Related PR/s

How to test

Dev-ops

@YuryHrytsuk
Shorten traefik config placeholder svc name
216962c 
The name is service name is too long and causes >64 len char issue when
deploying in prod. This fixes the problem by using a short name

Related PR/s
* original introduction of this servicehttps://github.com/ITISFoundation/pull/7899
* corresponding ops changes ITISFoundation/osparc-ops-environments#1177
@YuryHrytsuk YuryHrytsuk added this to the Voyager milestone Aug 14, 2025
@YuryHrytsuk YuryHrytsuk self-assigned this Aug 14, 2025
@YuryHrytsuk YuryHrytsuk added the 🤖-automerge marks PR as ready to be merged for Mergify label Aug 14, 2025
@YuryHrytsuk
Copy link
Contributor Author

YuryHrytsuk commented Aug 14, 2025

@mergify queue

@codecov
Copy link

codecov bot commented Aug 14, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.08%. Comparing base (f00ff11) to head (8a32fd5).
⚠️ Report is 38 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8217      +/-   ##
==========================================
+ Coverage   86.09%   88.08%   +1.99%     
==========================================
  Files        1910     1910              
  Lines       73396    73396              
  Branches     1301     1301              
==========================================
+ Hits        63191    64653    +1462     
+ Misses       9817     8356    -1461     
+ Partials      388      387       -1
Flag Coverage Δ
integrationtests 64.35% <ø> (+0.13%) ⬆️
unittests 86.72% <ø> (+2.13%) ⬆️
Components Coverage Δ
pkg_aws_library 93.93% <ø> (ø)
pkg_celery_library 87.37% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.03% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.02% <ø> (ø)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library 71.72% <ø> (+0.02%) ⬆️
pkg_settings_library 90.46% <ø> (ø)
pkg_simcore_sdk 85.10% <ø> (+0.05%) ⬆️
agent 93.81% <ø> (ø)
api_server 93.20% <ø> (ø)
autoscaling 95.89% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.14% <ø> (ø)
director_v2 91.03% <ø> (+0.06%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.12% <ø> (ø)
efs_guardian 89.60% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.60% <ø> (ø)
resource_usage_tracker 92.55% <ø> (+0.37%) ⬆️
storage 86.46% <ø> (-0.25%) ⬇️
webclient ∅ <ø> (∅)
webserver 88.20% <ø> (+6.72%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f00ff11...8a32fd5. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Aug 14, 2025 •
edited
Loading

queue

🛑 Configuration not compatible with a branch protection setting

The branch protection setting Require branches to be up to date before merging is not compatible with max_parallel_checks>1, queue_conditions != merge_conditions and must be unset.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mergify
Copy link
Contributor

mergify bot commented Aug 14, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 8a32fd5.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on base branch Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@YuryHrytsuk YuryHrytsuk merged commit cebad23 into ITISFoundation:master Aug 14, 2025
95 checks passed
@YuryHrytsuk YuryHrytsuk removed the 🤖-automerge marks PR as ready to be merged for Mergify label Aug 14, 2025
@YuryHrytsuk YuryHrytsuk deleted the shorten-traefik-placeholder-service branch August 14, 2025 13:55
@YuryHrytsuk
Copy link
Contributor Author

YuryHrytsuk commented Aug 14, 2025

@matusdrobuliak66 please tag in v1.84.1

matusdrobuliak66 pushed a commit to matusdrobuliak66/osparc-simcore that referenced this pull request Aug 18, 2025
@YuryHrytsuk @matusdrobuliak66
♻️ Shorten traefik config placeholder svc name (ITISFoundation#8217)
a6ba9b5
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Aug 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
Closed
61 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2025
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

Assignees

@YuryHrytsuk YuryHrytsuk

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Voyager

Development

Successfully merging this pull request may close these issues.

4 participants

@YuryHrytsuk @mrnicegyu11 @sanderegg @matusdrobuliak66